Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent errors if Tween callback's object is freed #81127

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 29, 2023

This PR prevents errors when the callback target of CallbackTweener or MethodTweener is freed. This is consistent with PropertyTweener.

Related: #81087 and the linked issue.

@KoBeWi KoBeWi added this to the 4.x milestone Aug 29, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner August 29, 2023 12:49
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 29, 2023
@akien-mga akien-mga merged commit 922689c into godotengine:master Aug 29, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the errors_begone branch August 29, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants