Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump version for actions/checkout@v4 and actions/setup-dotnet@v3 #81302

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Sep 4, 2023

Let's give this a bit before merging, the actions/checkout@v4 release has just been tagged, and all @v3 actions seem to have broken: actions/checkout#1448

Let's see if they decide to roll things back or what the resolution will be.

Edit: Seems like the incident got resolved, the update should be fine. It's mostly just changing the Node version used, and it doesn't really matter for us.

@akien-mga akien-mga added enhancement topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 4, 2023
@akien-mga akien-mga added this to the 4.2 milestone Sep 4, 2023
@akien-mga akien-mga requested a review from a team as a code owner September 4, 2023 14:07
@akien-mga akien-mga marked this pull request as draft September 4, 2023 14:25
@akien-mga akien-mga marked this pull request as ready for review September 4, 2023 15:29
@akien-mga
Copy link
Member Author

actions/checkout@v3 is having another set of random failures. So far the reports seem to indicate that @v4 works better, not clear whether it's just placebo but let's see if it helps.

@akien-mga akien-mga merged commit e720842 into godotengine:master Sep 5, 2023
15 checks passed
@akien-mga akien-mga deleted the gha-bump-versions branch September 5, 2023 08:13
@akien-mga
Copy link
Member Author

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 6, 2023
@akien-mga
Copy link
Member Author

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Sep 6, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants