Codestyle: Don't use auto where not warranted #81414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Sep 7, 2023
tests/scene/test_arraymesh.h
Outdated
| @@ -195,7 +195,7 @@ TEST_CASE("[SceneTree][ArrayMesh] Surface metadata tests.") { | |||
| } | |||
|
|
|||
| SUBCASE("Returns correct format for the mesh") { | |||
| auto format = RS::ARRAY_FORMAT_BLEND_SHAPE_MASK | RS::ARRAY_FORMAT_TEX_UV | RS::ARRAY_FORMAT_INDEX; | |||
| RS::ArrayFormat format = RS::ARRAY_FORMAT_BLEND_SHAPE_MASK | RS::ARRAY_FORMAT_TEX_UV | RS::ARRAY_FORMAT_INDEX; | |||
There was a problem hiding this comment.
Example of why auto isn't good when the type should be clear...
invalid conversion from 'int' to 'RenderingServer::ArrayFormat' [-fpermissive]
akien-mga
force-pushed
the
codestyle-get-back-in-das-Auto
branch
from
eabb977
to
7d6bb4c
Compare
|
What about: godot/modules/openxr/scene/openxr_hand.cpp Lines 216 to 217 in d6d8cb1 |
|
I missed those, my regex was |
|
Also: godot/modules/openxr/openxr_api.cpp Line 304 in d6d8cb1 That one would be Otherwise I can't find any myself |
We allow using auto for lambdas or complex macros where a return type may change based on the parameters. But where the type is clear, we should be explicit. Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
akien-mga
force-pushed
the
codestyle-get-back-in-das-Auto
branch
from
7d6bb4c
to
1151866
Compare
akien-mga
commented
Sep 7, 2023
| @@ -2077,7 +2076,7 @@ XRPose::TrackingConfidence _transform_from_location(const T &p_location, Transfo | |||
| Basis basis; | |||
| Vector3 origin; | |||
| XRPose::TrackingConfidence confidence = XRPose::XR_TRACKING_CONFIDENCE_NONE; | |||
| const auto &pose = p_location.pose; | |||
| const XrPosef &pose = p_location.pose; | |||
There was a problem hiding this comment.
I had to look up what types T can take, where it's defined in openxr.h, to know which type its pose member uses. This really should be explicit for the reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow using auto for lambdas or complex macros where a return type may change based on the parameters. But where the type is clear, we should be explicit.
https://www.youtube.com/watch?v=z87g8IQTVjw