SceneTreeDock: Remove animation tracks with correct indices #81651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:editor
topic:animation
cherrypick:4.1
YuriSizov
reviewed
Sep 14, 2023
|
While the trick makes sense, wouldn't it be more convenient to start from the end? That way indices are not changing under your feet. |
|
I tried to start from the end but it became a bit complicated to handle the undo part as removed tracks would need to be reinserted in reverse order. |
garychia
force-pushed
the
delete_anim_tracks
branch
from
2deab83
to
3d7facd
Compare
YuriSizov
approved these changes
Sep 15, 2023
fire
approved these changes
Sep 15, 2023
|
Thanks! |
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81602
The index of an animation track to be removed was not determined correctly.
HashSetwas used to find out the updated index but it does not always keep its keys in the same order after erasing a key.