Fix GodotPhysicsDirectBodyState2D get_contact_impulse to return current physics step impulse #81654
+50
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlugeNico
force-pushed
the
fix-get_contact_impulse
branch
from
573b58a
to
d3efd3c
Compare
|
FWIW, I've tested this by cherry picking onto my fork, and the impulse values look good to me. |
| } | ||
| if (B->can_report_contacts()) { | ||
| B->add_contact(global_B + offset_A, c.normal, depth, shape_B, c.initial_rB, global_A + offset_A, shape_A, | ||
| A->get_instance_id(), A->get_self(), c.initial_rA, c.acc_impulse); } |
There was a problem hiding this comment.
Suggested change
| A->get_instance_id(), A->get_self(), c.initial_rA, c.acc_impulse); } | |
| A->get_instance_id(), A->get_self(), c.initial_rA, c.acc_impulse); | |
| } |
Reicher
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
GodotPhysicsDirectBodyState2D get_contact_impulse() function returns wrong value. Initial it returns just a Vector2.ZERO.
The problem is, that not the final impulse sum is used, but the value generated in pre_solve().
Solution:
The only solution I found was to add a function that's called after solve(). It's called post_solve and is optional for stuff that must be done in a GodotConstraint2D after being solved. Here we can add the collision contact info with all required information, instead of adding it in pre_solve(), where some information (the impulse sum) is missing.
Same issue for 3D:
#73569