GDScript: Add check for super() methods not being implemented
#81808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvilfolk
force-pushed
the
super-virtual
branch
from
433ce42
to
bcc8166
Compare
modules/gdscript/tests/scripts/analyzer/features/virtual_method_implemented.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/tests/scripts/analyzer/features/virtual_method_implemented.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/tests/scripts/analyzer/features/virtual_method_implemented.gd
Outdated
Show resolved
Hide resolved
adamscott
added
the
cherrypick:4.1
anvilfolk
force-pushed
the
super-virtual
branch
from
bcc8166
to
729c9b4
Compare
|
Force push was just the comment fixes! :) |
|
Thanks! |
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back what I believe is the OK part of #77324. When checking a
super()call in GDScript, we know what the base class is, and can check up the class hierarchy whether the method exists.The reason that part of #77324 was reverted was because in the general case, when calling any method on any object (e.g. a random node in the scene tree), we can't guarantee that the object doesn't have a script attached (that we don't know of) that implements the method. I don't think this can happen here, because it is specifically for
super()calls.Fixes #81804.