Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose texture_create_from_extension to GDExtension #82168

Merged
merged 1 commit into from Sep 24, 2023
Merged

Expose texture_create_from_extension to GDExtension #82168

merged 1 commit into from Sep 24, 2023

Conversation

Supreeeme
Copy link
Contributor

This function is necessary for XR extensions and is used by the OpenXR extension, yet is seemingly absent from the GDExtensions/GDScript interface. This fixes that.

@Supreeeme Supreeeme requested review from a team as code owners September 23, 2023 05:46
@Chaosus Chaosus added this to the 4.2 milestone Sep 23, 2023
@BastiaanOlij
Copy link
Contributor

Looks good but I don't think you need to introduce _texture_create_from_extension, you can bind texture_create_from_extension directly. The extra method is only needed when wrapper parameters are needed for structures that can't be bound.

BastiaanOlij
BastiaanOlij approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, indeed very userful for XR GDExtension plugins. Was actually surprised we didn't expose this already.

@akien-mga akien-mga changed the title Expose texture_create_from_extension to GDExtension Expose texture_create_from_extension to GDExtension Sep 24, 2023
@akien-mga akien-mga merged commit 64cde8a into godotengine:master Sep 24, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
enhancement topic:gdextension topic:rendering
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Supreeeme @BastiaanOlij @akien-mga @Chaosus