Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that resource_name is not always supported #82406

Merged

Conversation

BorisTheBrave
Copy link
Contributor

@BorisTheBrave BorisTheBrave commented Sep 26, 2023

Warning about the problem described in #82333

Bugsquad edit:

@BorisTheBrave BorisTheBrave requested a review from a team as a code owner September 26, 2023 21:28
doc/classes/Resource.xml Outdated Show resolved Hide resolved
doc/classes/Resource.xml Outdated Show resolved Hide resolved
@BorisTheBrave BorisTheBrave force-pushed the doc-resource_name-unsupported branch 3 times, most recently from ece07b1 to 5256eaf Compare October 1, 2023 15:45
doc/classes/Resource.xml Outdated Show resolved Hide resolved
@YuriSizov YuriSizov changed the title Doc: resource_name is not always supported. Document that resource_name is not always supported Oct 30, 2023
@YuriSizov
Copy link
Contributor

Needs some adjustments to the note. Also, could you please amend the commit message to follow our prefer format (starts with a verb describing the action, followed by the subject of the change)? The current title of the PR is a good option.

@YuriSizov YuriSizov modified the milestones: 4.2, 4.3 Oct 30, 2023
@BorisTheBrave
Copy link
Contributor Author

could you please

No, I could not. I've had my suggested change shot down three times now, for a one line doc change, and now you want the commit message changed too (not mentione after it was ignored for months). I've lost all enthusiasm for driving this forward. Clearly things must be done exactly right here, and I don't know how, so you can sort it out yourselves.

@akien-mga
Copy link
Member

That's understandable. We have both a significant backlog to review with limited resources, and high quality standards to ensure that what gets merged is correct and does not add to tech debt that would be hard to manage with scale.

It's totally ok to opt out of the process if it's too cumbersome, we understand it's not for everyone.

Do you mind if we take over this PR to do the final touches ourselves so that it can be merged?

@BorisTheBrave
Copy link
Contributor Author

Feel free

Closes godotengine#82333.

Co-authored-by: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
@akien-mga akien-mga force-pushed the doc-resource_name-unsupported branch from a8f11f3 to a390996 Compare November 1, 2023 09:44
@akien-mga akien-mga modified the milestones: 4.3, 4.2 Nov 1, 2023
@akien-mga akien-mga merged commit 136c4e3 into godotengine:master Nov 1, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceName not saved
5 participants