Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debugger behavior with multi-session debugging #82868

Merged
merged 1 commit into from Oct 16, 2023
Merged

Fix debugger behavior with multi-session debugging #82868

merged 1 commit into from Oct 16, 2023

Conversation

SaracenOne
Copy link
Member

This fixes several bugs in the in-editor debugger associated with the ability to launch multiple instances of a game for the purpose of testing multiplayer logic locally.

  • It fixes the script editors debug menu containing step, break, and continue, which do not work if launched from an instance session other than session 1. It also correctly contextually greys out options depending on whether the session has hit a break point or not.
  • Adds proper callbacks to all breakpoints to be removed when toggle from the breakpoints menu in a session tab other than 1.
  • Stops the execution indicator from appearing when switching tabs to a session which has not hit a breakpoint.

This has not been tested with external debuggers, but at the very least, I don't expect it cause regressions, but would recommend a review from someone actively making use of an external debugger.

Closes #82867

@SaracenOne SaracenOne added this to the 4.2 milestone Oct 5, 2023
@SaracenOne SaracenOne requested review from a team as code owners October 5, 2023 16:59
@SaracenOne SaracenOne marked this pull request as draft October 6, 2023 00:45
@SaracenOne
Copy link
Member Author

Putting this back under draft for the time being. There's still some issues.

@SaracenOne
Fix debugger behaviour with multi-session debugging:
3defc17 
Fixes script editor debug menu on sessions other than 1
Fixes breakpoint toggle from menu in sessions other than 1
Removes execution display when switching to non-breaked sessions
@SaracenOne SaracenOne marked this pull request as ready for review October 6, 2023 18:31
@SaracenOne
Copy link
Member Author

Okay, reopening this since I think I've resolved the issue now.

Faless
Faless approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🏆 !

I've tested it a bit with a couple a project, seems to work seamlessly.

@akien-mga akien-mga merged commit c2d410a into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Fix debugger behaviour with multi-session debugging Fix debugger behavior with multi-session debugging Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

In-editor debugger has broken options when running multiple instances/sessions
3 participants
@SaracenOne @akien-mga @Faless