Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close shader in Shader Editor tab when deleting shader file in FileSystem panel #83137

Merged
merged 1 commit into from Oct 16, 2023
Merged

Close shader in Shader Editor tab when deleting shader file in FileSystem panel #83137

merged 1 commit into from Oct 16, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #72595

It works as the same with built-in script editor, when you delete the file in the filesystem panel, the editor should close the relating tab.

@jsjtxietian jsjtxietian marked this pull request as ready for review October 11, 2023 09:52
@jsjtxietian jsjtxietian requested a review from a team as a code owner October 11, 2023 09:52
@akien-mga akien-mga added this to the 4.2 milestone Oct 11, 2023
@akien-mga akien-mga requested a review from a team October 11, 2023 10:04
SaracenOne
SaracenOne approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsjtxietian jsjtxietian force-pushed the close-shader-file-in-visual-editor-when-delete-file branch from 166102c to 10d77b3 Compare October 16, 2023 08:58
@jsjtxietian jsjtxietian force-pushed the close-shader-file-in-visual-editor-when-delete-file branch from 10d77b3 to 15e66cc Compare October 16, 2023 10:51
@akien-mga akien-mga merged commit 0258fa4 into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the close-shader-file-in-visual-editor-when-delete-file branch October 16, 2023 11:23
@KoBeWi
Copy link
Member

KoBeWi commented Nov 8, 2023

I just discovered that set_meta() is used wrongly here. It gets attached to shaders and saved in the file, which shouldn't be happening.

@KoBeWi KoBeWi mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:shaders usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Deleting Shader file in FileSystem panel leaves shader file open for editing in Shader Editor tab
5 participants
@jsjtxietian @akien-mga @KoBeWi @SaracenOne @AThousandShips