Fix unit suffixes for Generic6DOFJoint
#83672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Oct 20, 2023
AThousandShips
approved these changes
Oct 20, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic6DOFJointcurrently lacks suffixes for a couple of its properties. For the most part this is just a matter of visual aid, but in the case of the angular "Equilibrium Point" properties, as well as the angular "Target Velocity" properties (similar to #80523), this also changes them to be displayed in degrees rather than the radians that they're intended to be stored as.The changes are as follows:
kg⋅m/s² (N)mkg⋅m²/s² (Nm)radians_as_degrees°/skg⋅m²/s² (Nm)radians_as_degrees(and thus suffix°)None of these should be breaking changes, as far as I know.