Fix missing NavigationRegion property updates in constructor #83812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2023
smix8
added
the
cherrypick:4.2
YuriSizov
reviewed
Dec 4, 2023
YuriSizov
reviewed
Dec 4, 2023
Fixes missing NavigationRegion property updates in constructor.
smix8
force-pushed
the
navregion_properties
branch
from
ee2e103
to
25bf20d
Compare
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing NavigationRegion property updates in constructor.
Region version of #83802 and #83814.
Also added the missing
get_rid()function that every navigation related node should have exposed and marked the oldget_region_rid()function deprecated.The NavigationRegion was the odd one that had a different name for this compared to every other navigation related node that uses get_rid().