Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate TextEdit placeholder #83946

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Translate TextEdit placeholder #83946

merged 1 commit into from
Oct 26, 2023

Conversation

timothyqiu
Copy link
Member

Fixes #83942

@timothyqiu timothyqiu added bug topic:gui cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 25, 2023
@timothyqiu timothyqiu added this to the 4.2 milestone Oct 25, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner October 25, 2023 14:54
akien-mga
akien-mga approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. _update_placeholder seems to be called only when necessary, so this seems ok without further caching mechanism.

@akien-mga akien-mga merged commit 70f50c9 into godotengine:master Oct 26, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the text-edit-placeholder branch October 26, 2023 07:09
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

TextEdit placeholder text not automatically translated
4 participants
@timothyqiu @akien-mga @YuriSizov @KoBeWi