Fix crash when reimporting with Skeleton3D selected. #83964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
SaracenOne
force-pushed
the
skeleton_reimport_crashfix
branch
from
ee5fb4d
to
b93ec74
Compare
fire
reviewed
Oct 25, 2023
SaracenOne
force-pushed
the
skeleton_reimport_crashfix
branch
from
b93ec74
to
ed083a9
Compare
fire
approved these changes
Oct 25, 2023
akien-mga
approved these changes
Oct 25, 2023
|
tl;dr Get parent returns a null sometimes. An obvious uncommon case would be when you've got a mesh instance 3d root and you have a children skeleton. The get_parent() of the mesh instance 3d root is null. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74059