Ignore path error for built-in scripts/shaders #84077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84071
Regression from #78744
ShaderCreateDialog does not validate path when using built-in shader. While it's correct, if the path was invalid before enabling the checkbox, it will be considered invalid for built-in scripts and fail. This PR makes the error ignored if shader is built-in (I could clear the error instead, but ignoring it is safer).
ScriptCreateDialog has the same problem, but it assigns a path based on node name, so it wasn't visible. Meantime shader uses scene name, which can be empty.