Fix PlaneMesh tangents for 'Face X' orientation #84097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
This pull request would change it in the FACE_X case to (0, 0, -1) which makes it match the others AFAICT.
Can confirm, for other primitive meshes their tangents are into the right (+U) of the texture. For PlaneMesh tangents for FACE_Y/FACE_Z orientations are already consistent with that, and for FACE_X tangent should indeed be -Z. 👍
FACE_Y |
FACE_Z |
FACE_X |
|
|---|---|---|---|
| This PR |  |
 |
 |
| v4.2.beta3.official [e8d57af] | the same | the same |  |
clayjohn
approved these changes
Oct 29, 2023
clayjohn
added
the
cherrypick:4.1
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlaneMesh currently uses tangent (1, 0, 0) for all orientations. But the normal for the FACE_X orientation is also (1, 0, 0) so normal maps don't currently work. This pull request would change it in the FACE_X case to (0, 0, -1) which makes it match the others AFAICT.
Before, with Z, Y, X orientations, and a second set all rotated to face Z:
After:
