Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent encoding/decoding objects that cannot be instantiated #84611

Merged
merged 1 commit into from Dec 19, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Nov 8, 2023

Ensures that encoding classes that cannot be instantiated errors, both when encoding and decoding

Could make the error message more descriptive but starting out simple

The decoding side isn't necessarily needed but it reduces the error count and could add a clearer message as well there (though I think the error return is better, ERR_INVALID_DATA over ERR_UNAVAILABLE)

@AThousandShips AThousandShips added this to the 4.3 milestone Nov 8, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner November 8, 2023 10:56
@AThousandShips AThousandShips changed the title Prevent encoding objects that cannot be instantiated Prevent encoding/decoding objects that cannot be instantiated Nov 8, 2023
@YuriSizov YuriSizov requested a review from Faless November 8, 2023 13:48
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , thanks for looking into it 🏆

@YuriSizov YuriSizov merged commit 6fc92e1 into godotengine:master Dec 19, 2023
15 checks passed
@AThousandShips AThousandShips deleted the encode_invalid branch December 19, 2023 19:37
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects of custom instance classes cannot be decoded by marshalls
3 participants