Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Vector2/3/4I.Min/Max to MinValue/MaxValue #84663

Merged
merged 1 commit into from Nov 9, 2023
Merged

Rename Vector2/3/4I.Min/Max to MinValue/MaxValue #84663

merged 1 commit into from Nov 9, 2023

Conversation

AThousandShips
Copy link
Member

More consistent with the Mathf constants they reference

As discussed in #80223 (comment)

@AThousandShips
Rename Vector2/3/4I.Min/Max to MinValue/MaxValue
668761f 
More consistent with the `Mathf` constants they reference
@AThousandShips AThousandShips added this to the 4.2 milestone Nov 9, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner November 9, 2023 13:18
@AThousandShips AThousandShips mentioned this pull request Nov 9, 2023
Merged
raulsntos
raulsntos approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@YuriSizov
Copy link
Contributor

While this only breaks compatibility with previous 4.2 dev builds, it still needs to be labeled as such.

@akien-mga akien-mga merged commit 884c794 into godotengine:master Nov 9, 2023
15 checks passed
@AThousandShips AThousandShips deleted the cs_rename branch November 9, 2023 17:21
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

@Chubercik Chubercik Chubercik approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AThousandShips @YuriSizov @akien-mga @raulsntos @Chubercik