Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tree's set_selected check if the TreeItem belongs to the tree #84870

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Make Tree's set_selected check if the TreeItem belongs to the tree #84870

merged 1 commit into from
Nov 14, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #84862

@jsjtxietian jsjtxietian requested a review from a team as a code owner November 14, 2023 03:29
jsjtxietian
jsjtxietian commented Nov 14, 2023
View reviewed changes
scene/gui/tree.cpp Outdated Show resolved Hide resolved
@AThousandShips AThousandShips added this to the 4.3 milestone Nov 14, 2023
@akien-mga akien-mga changed the title Make Tree's set_selected check if treeitem belongs to the tree Make Tree's set_selected check if the TreeItem belongs to the tree Nov 14, 2023
@akien-mga akien-mga modified the milestones: 4.3, 4.2 Nov 14, 2023
@akien-mga akien-mga merged commit c26b36e into godotengine:master Nov 14, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the add-set-selected-protection branch November 15, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug crash topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Tree's set_selected() does not check if TreeItem belongs to the Tree
4 participants
@jsjtxietian @akien-mga @KoBeWi @AThousandShips