Fix issue causing Godot Android apps / games to freeze on close #85454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue occurred because during the 'close' event, the logic was trying to terminate the native engine on the UI thread instead of doing on the render thread.
akien-mga
approved these changes
Nov 28, 2023
|
Thanks! |
|
In which version is this error going to be fixed ? |
|
@ZishAan23 This is a part of Godot 4.2, released 3 weeks ago. |
|
@YuriSizov if the error is fixed in Godot 4.2 then why my Godot editor is still causing the same issue. One error is fixed that is whenever I want to exit from my game and return to editor I can easily tap the back button and exit. However when an error occurs the same thing happens the back button doesn't work. Is there a new setting or something that I have to change to fix the issue? |
|
@ZishAan23 This PR is addressing a very broad problem of Android apps and games freezing. There can be many reasons for why this happens. Please file a bug report with your example and a reproduction project so it can be debugged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occurred because during the 'close' event, the logic was trying to terminate the native engine on the UI thread instead of doing on the render thread.