Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AnimationPlayer seeking for Discrete keys #85569

Merged
merged 1 commit into from Dec 4, 2023

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Nov 30, 2023

Internal seeking exists to determine the start of playback in AnimationNodes on the AnimationTree. So in the AnimationPlayer, this should always be true, since AnimationPlayer doesn't have internal seeking.

Also the playback process has changed with the AnimationMixer implementation, and the timing of the animation time advance has changed, so the fix in #80708 should not need to be considered.

Tested with #80640 and confirm it is working correctly.

@TokageItLab TokageItLab added bug regression topic:animation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 30, 2023
@TokageItLab TokageItLab added this to the 4.3 milestone Nov 30, 2023
@TokageItLab TokageItLab requested a review from a team as a code owner November 30, 2023 20:31
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand this, but the pr is a single line and written by the primary animation team developer. So the pull request looks good to me.

@LakshayaG73
Copy link

I can confirm that this fixes #85129 and doesn't seem to introduce any new issues in my project.

@akien-mga akien-mga merged commit b8ba602 into godotengine:master Dec 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@TokageItLab TokageItLab deleted the fix-seek-diecrete branch February 14, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants