Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a descriptive error message when creating a mesh surface from the wrong array type #85646

Merged
merged 1 commit into from Dec 4, 2023
Merged

Add a descriptive error message when creating a mesh surface from the wrong array type #85646

merged 1 commit into from Dec 4, 2023

Conversation

aaronfranke
Copy link
Member

I was confused for a few minutes because I was using Array by accident.

@aaronfranke aaronfranke added this to the 4.3 milestone Dec 2, 2023
@aaronfranke aaronfranke requested a review from a team as a code owner December 2, 2023 07:16
clayjohn
clayjohn approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@clayjohn clayjohn added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 4, 2023
@akien-mga akien-mga merged commit 7b2b408 into godotengine:master Dec 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the mesh-surf-arr-msg branch December 5, 2023 00:32
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aaronfranke @akien-mga @YuriSizov @clayjohn