Fix mouse_in_window state with confined mouse
#85872
Draft
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_update_mouse_over` is called whenever the mouse is over the Window. So `mouse_in_window` needs to be set in all cases.
Sauermann
added
bug
topic:core
topic:input
regression
cherrypick:4.2
akien-mga
previously approved these changes
Dec 7, 2023
|
Are there still outstanding issues with this PR, or was it just put back in draft for some further testing? |
|
I put the PR into draft status, because during my tests I found a bug. A more elaborate solution would be necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_update_mouse_overis called whenever the mouse is over the Window. Somouse_in_windowneeds to be set in all cases.resolve #85713
regression from #80334