GDScript: Adjust STATIC_CALLED_ON_INSTANCE warning to not force native type
#85918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnen
approved these changes
Feb 8, 2024
akien-mga
changed the title
STATIC_CALLED_ON_INSTANCE warning to not force native type
|
Note that for non-global classes the warning will suggest invalid code. |
Example, please? I'm not sure what constitutes a "non-global class" in this case. |
|
|
Note that this would be wrong on the current master also, it would show We can either accept this as small improvement or work on a proper fix that finds the origin of method. PS: I wonder if we should even emit this warning with a direct call for a function in the same class. If it does not have |
20kdc
added a commit
to 20kdc/godot
that referenced
this pull request
Feb 9, 2024
…the native type, and to not trigger on self-calls Not defaulting to the native type rationale: Defaulting to the native type is less than useful, as: * There are very few native types that are extensible and have static methods. * Defaulting to the native type does not account for a method being script-defined. While the "real fix" would be to carefully track the source of the method, the get_function_signature method is already complicated enough. This will at least ensure the resulting code should always be valid. Not triggering on self-calls rationale: Found in PR comment godotengine#85918 (comment) ``` static func example(): pass func example2(): example() # self-call on static function ``` Disabling this warning on self-calls is: * Consistent with other languages * Important for anonymous classes (where the output code is unusable)
20kdc
force-pushed
the
tnj-static-called-on-instance-fix-confusion
branch
from
3434530
to
e6fe75b
Compare
|
I've amended my commit on the basis of that other languages don't warn for these kinds of self-calls to static functions. There are more examples and counter-examples one could add involving |
dalexeev
reviewed
Feb 12, 2024
modules/gdscript/tests/scripts/parser/warnings/static_called_on_instance.gd
Show resolved
Hide resolved
modules/gdscript/tests/scripts/parser/warnings/static_called_on_instance.out
Show resolved
Hide resolved
…the native type, and to not trigger on self-calls Not defaulting to the native type rationale: Defaulting to the native type is less than useful, as: * There are very few native types that are extensible and have static methods. * Defaulting to the native type does not account for a method being script-defined. While the "real fix" would be to carefully track the source of the method, the get_function_signature method is already complicated enough. This will at least ensure the resulting code should always be valid. Not triggering on self-calls rationale: Found in PR comment godotengine#85918 (comment) ``` static func example(): pass func example2(): example() # self-call on static function ``` Disabling this warning on self-calls is: * Consistent with other languages * Important for anonymous classes (where the output code is unusable)
dalexeev
force-pushed
the
tnj-static-called-on-instance-fix-confusion
branch
from
e6fe75b
to
24181d1
Compare
dalexeev
approved these changes
Mar 1, 2024
|
Thanks! |
sambler
pushed a commit
to sambler/godot
that referenced
this pull request
Apr 6, 2024
…the native type, and to not trigger on self-calls Not defaulting to the native type rationale: Defaulting to the native type is less than useful, as: * There are very few native types that are extensible and have static methods. * Defaulting to the native type does not account for a method being script-defined. While the "real fix" would be to carefully track the source of the method, the get_function_signature method is already complicated enough. This will at least ensure the resulting code should always be valid. Not triggering on self-calls rationale: Found in PR comment godotengine#85918 (comment) ``` static func example(): pass func example2(): example() # self-call on static function ``` Disabling this warning on self-calls is: * Consistent with other languages * Important for anonymous classes (where the output code is unusable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulting to the native type is less than useful, as:
While the "real fix" would be to carefully track the source of the method, the get_function_signature method is already complicated enough.
This will at least ensure the resulting code should always be valid.
This PR was written after seeing the following warning:
Where
get_absolute_z_index()was a static function declared in a script (and thus did not exist in Node2D, and thus the given code did not work)