Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileAccessPack::get_buffer updating position past the length of file #85991

Merged
merged 1 commit into from Dec 18, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #85921

@jsjtxietian jsjtxietian requested a review from a team as a code owner December 10, 2023 08:22
@akien-mga akien-mga added bug topic:core cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 10, 2023
@akien-mga akien-mga added this to the 4.3 milestone Dec 10, 2023
@akien-mga akien-mga changed the title Fix FileAccessPack::get_buffer will update pos past the length of file Fix FileAccessPack::get_buffer will update pos past the length of file Dec 11, 2023
@YuriSizov YuriSizov changed the title Fix FileAccessPack::get_buffer will update pos past the length of file Fix FileAccessPack::get_buffer updating position past the length of file Dec 18, 2023
@YuriSizov YuriSizov merged commit a9a5093 into godotengine:master Dec 18, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@jsjtxietian jsjtxietian deleted the fix-bad-pos-state branch December 19, 2023 02:19
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileAccessPack::get_buffer moves the cursor past the end of file
3 participants