Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in AudioStreamPlaybackPolyphonic where stream IDs returned from play_stream may not work #86054

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug in AudioStreamPlaybackPolyphonic where stream IDs returned from play_stream may not work #86054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4498c8c
Fix bug in AudioStreamPlaybackPolyphonic where stream IDs returned fr…
xerothermic06 Dec 11, 2023
fbd7ebb
Update scene/resources/audio_stream_polyphonic.h
xerothermic06 Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scene/resources/audio_stream_polyphonic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class AudioStreamPolyphonic : public AudioStream {
class AudioStreamPlaybackPolyphonic : public AudioStreamPlayback {
GDCLASS(AudioStreamPlaybackPolyphonic, AudioStreamPlayback)

enum {
enum : uint64_t {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enum : uint64_t {
enum : uint32_t {

should be sufficient, as ID_MASK equals max unsigned 32

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xerothermic06: ping

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really matter I'd say as it's not used for storage anywhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discarding the suggestion is fine, too.

Though getting this merged would be nice…

INTERNAL_BUFFER_LEN = 128,
ID_MASK = 0xFFFFFFFF,
INDEX_SHIFT = 32
Expand Down
Loading