Fix Android dynamic library loading #86792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c library loading
|
cc @dsnopek @akien-mga We should include this fix in the dev2 build (or revert the original PR) to avoid introducing a regression on Android for dev2. |
dsnopek
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Per our discussion on PR #86794, there may not be a way to reliably distinguish between "not found" and "cannot load". So, let's just go with reverting for now.
But it would definitely provide a better developer experience for GDExtension if we were able to come up with a way to distinguish between those, at least in the most common cases.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #86682 for the Android platform as it breaks dynamic library loading