Fix floor snapping for CSG shapes with collision #89833
Open
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenjt
force-pushed
the
fix-snap-floor-csg-collision
branch
from
75bdad2
to
ffea06f
Compare
|
I think this is right but can't code review for the next few days. |
stevenjt
force-pushed
the
fix-snap-floor-csg-collision
branch
from
ffea06f
to
27ceb35
Compare
|
After having another look at this I've added the method binding + doc description so this new CSGShape3D function is accessible from the scripting interface, just as get_rid is for CollisionObject3D derived classes. |
Add get_collision_rid function to CSGShape3D. Add additional checks when gathering nodes to exclude from raycast made when using the Snap Object to Floor feature of the 3D editor so that it finds and includes CSGShape3Ds that have collision enabled.
stevenjt
force-pushed
the
fix-snap-floor-csg-collision
branch
from
27ceb35
to
cad6e68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #89832
I found that the cause of this behaviour was that the CSG Shapes with collision enabled were not being included in the exclude list for the raycast that finds the object/floor underneath being placed. This is because they do not use PhysicsBody3D but instead use PhysicsServer3D directly. At certain sizes, specifically small sizes, the raycast can then hit the object that is meant to be being placed causing it to be pushed up.
To fix this I have done the following: