Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the gradle build logic used to generate the Godot Android binaries #91271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clean up the gradle build logic used to generate the Godot Android binaries #91271

wants to merge 2 commits into from
+110 −219

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 28, 2024

No description provided.

@m4gr3d m4gr3d added this to the 4.4 milestone Apr 28, 2024
@m4gr3d m4gr3d requested a review from raulsntos April 28, 2024 05:30
@m4gr3d m4gr3d requested a review from a team as a code owner April 28, 2024 05:30
@m4gr3d m4gr3d mentioned this pull request Apr 28, 2024
Draft
raulsntos
raulsntos approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak for the Android team, but this looks reasonable to me and helps me implement #88803. Thank you!

@m4gr3d m4gr3d force-pushed the clean_gradle_build_setup branch from 86520a3 to f63fbc8 Compare May 3, 2024 06:51
raulsntos
raulsntos reviewed May 13, 2024
View reviewed changes
platform/android/java/build.gradle Outdated Show resolved Hide resolved
platform/android/java/build.gradle Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:buildsystem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4gr3d @raulsntos