Add automatic class_name generation for newly created scripts #91325
Conversation
Add automatic class_name generation when Add Type Hints is enabled
AThousandShips
changed the title
modules/gdscript/editor/script_templates/CharacterBody2D/basic_movement.gd
Show resolved
Hide resolved
|
I'd say this should always be opt-in, a lot of the time you don't want class names, I'd even say most of the time, nor are you guaranteed to need want it be the file name necessarily |
| @@ -79,7 +79,8 @@ Ref<Script> GDScriptLanguage::make_template(const String &p_template, const Stri | |||
| type_hints = EDITOR_GET("text_editor/completion/add_type_hints"); | |||
| #endif | |||
| if (!type_hints) { | |||
| processed_template = processed_template.replace(": int", "") | |||
| processed_template = processed_template.replace("class_name _CLASS_\n", "") | |||
There was a problem hiding this comment.
This will remove the class name for those templates where the name is required/desired.
There was a problem hiding this comment.
This actually does not remove the class name for these templates, since it is not the same string. Tested it.
There was a problem hiding this comment.
Those specific ones yes, but you can have custom templates, or we might add new ones
There was a problem hiding this comment.
Well, not here specifically, but in similar cases, if we or the user in a custom template omit/forget the prefix.
| @@ -1058,7 +1058,7 @@ | |||
| If [code]true[/code], uses [StringName] instead of [String] when appropriate for code autocompletion. | |||
| </member> | |||
| <member name="text_editor/completion/add_type_hints" type="bool" setter="" getter=""> | |||
| If [code]true[/code], adds [url=$DOCS_URL/tutorials/scripting/gdscript/static_typing.html]GDScript static typing[/url] hints such as [code]-> void[/code] and [code]: int[/code] when using code autocompletion or when creating onready variables by drag and dropping nodes into the script editor while pressing the [kbd]Ctrl[/kbd] key. If [code]true[/code], newly created scripts will also automatically have type hints added to their method parameters and return types. | |||
| If [code]true[/code], adds [url=$DOCS_URL/tutorials/scripting/gdscript/static_typing.html]GDScript static typing[/url] hints such as [code]-> void[/code] and [code]: int[/code] when using code autocompletion or when creating onready variables by drag and dropping nodes into the script editor while pressing the [kbd]Ctrl[/kbd] key. If [code]true[/code], newly created scripts will also automatically have type hints added to their method parameters and return types, as well as a generated [code]class_name[/code] based on the script's file name. | |||
There was a problem hiding this comment.
I don't see the point in adding additional behavior to an existing setting in this case. We could add a separate setting instead.
So where would you say this option should be available? In the mentioned issue it seems that people do not want it to be inside the create new script dialog either. |
|
I feel like it be more natural for this to be done in the Script creation dialog no? |
Add automatic class_name generation for newly created scripts when
Add Type Hintsis enabled.related to #9491
Feel free to suggest other ways to implement this instead, I just did what was most logical to me.