Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define uninitialized values for send in subviewport container. #91657

Closed
wants to merge 1 commit into from

Conversation

fire
Copy link
Member

@fire fire commented May 7, 2024

I was getting compiler errors about the send not being initialized.

@fire fire requested a review from a team as a code owner May 7, 2024 11:29
@akien-mga akien-mga added this to the 4.3 milestone May 7, 2024
@akien-mga

This comment was marked as resolved.

@akien-mga akien-mga requested a review from Sauermann May 7, 2024 11:34
@AThousandShips

This comment was marked as outdated.

@Sauermann
Copy link
Contributor

Sauermann commented May 7, 2024

send shouldn't be removed, because setting that variable is the intention of the virtual call. (resolved)
On which compiler do you experience the problem? It hasn't yet caused any problems within the usual Github checks.

@KoBeWi
Copy link
Member

KoBeWi commented May 7, 2024

This is a common pattern if the variable is used only after virtual call and is used in other places. E.g.

godot/core/math/a_star.cpp

Lines 395 to 398 in e001bc7

real_t scost;
if (GDVIRTUAL_CALL(_estimate_cost, p_from_id, p_to_id, scost)) {
return scost;
}

It's odd that you'd get a warning only in one case.

@fire
Copy link
Member Author

fire commented May 30, 2024

Close because I can't recreate the bug.

@fire fire closed this May 30, 2024
@akien-mga akien-mga removed this from the 4.3 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants