Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thorvg: Disable webp loader if corresponding module is disabled #91901

Merged

Conversation

akien-mga
Copy link
Member

Fixes #91873.

@akien-mga
Copy link
Member Author

akien-mga commented May 13, 2024

This should fix the logic, but further work seems needed (in a follow up).

From a quick test, I can't get SVG with embedded <image> bitmaps to be loaded in Godot, whether I use PNG, JPG or WebP.

They also don't show up in the ThorVG web viewer which seems to outright fail loading those SVGs.

Edit: It seems to work if the images are linked, but not embedded (base64). Judging by the ThorVG code there's no support implemented for embedded images? Need further investigation.

@hermet
Copy link

hermet commented May 14, 2024

@akien-mga hello, do you have a issued svg to test? thorvg basically supports the embedded images.

@fire
Copy link
Member

fire commented May 16, 2024

I have posted a image sample to thorvg.

@akien-mga akien-mga merged commit c4889e4 into godotengine:master May 17, 2024
16 checks passed
@akien-mga akien-mga deleted the scons-thorvg-webp-loader-opt-out branch May 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error related to thorvg and webp with webp module disabled
3 participants