Fix pausing issues when using Web Audio samples #93362
Merged
+117
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
adamscott
force-pushed
the
fix-web-audio-pause
branch
from
af063bd
to
ca77fb9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
adamscott
force-pushed
the
fix-web-audio-pause
branch
from
ca77fb9
to
bc9fb27
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
adamscott
force-pushed
the
fix-web-audio-pause
branch
from
bc9fb27
to
9559dc5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
adamscott
force-pushed
the
fix-web-audio-pause
branch
from
9559dc5
to
78c1cac
Compare
This comment was marked as resolved.
This comment was marked as resolved.
adamscott
force-pushed
the
fix-web-audio-pause
branch
from
78c1cac
to
247ede3
Compare
adamscott
force-pushed
the
fix-web-audio-pause
branch
from
247ede3
to
57db018
Compare
|
Can confirm, everything looks (and sounds) good now on my end! |
akien-mga
approved these changes
Jun 20, 2024
Maran23
approved these changes
Jun 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue identified by @Maran23 when pausing the game when using sample playback on the Web platform (#91382).
Now, the samples should pause and unpause without any issue.