Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zero-allocation section to README #3039

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add zero-allocation section to README #3039

merged 2 commits into from
Jun 20, 2024

Conversation

gaby
Copy link
Member

@gaby gaby commented Jun 19, 2024

Description

Update README to mention the Zero Allocation aspect of Fiber. Add LINK to documentation for further explanation. Update the wording in the "intro.md" section of the Docs.

Changes introduced

  • Documentation Update: Detail the updates made to the documentation and links to the changed files.

Type of change

  • Documentation update (changes to documentation)

@gaby gaby requested a review from a team as a code owner June 19, 2024 19:48
@gaby gaby requested review from sixcolors, ReneWerner87 and efectn and removed request for a team June 19, 2024 19:48
Copy link
Contributor

coderabbitai bot commented Jun 19, 2024

Walkthrough

This update enhances the Fiber web framework's README documentation to emphasize zero memory allocation and streamline versioning references. A new "Zero Allocation" section has been introduced to highlight this feature. Additionally, the introduction section of the Fiber framework's documentation was updated to clarify the mutable nature of fiber.Ctx values and best practices for handling contexts within request handlers.

Changes

File Change Summary
.github/README.md Updated description to emphasize zero memory allocation, added "Zero Allocation" section, adjusted versioning to "Fiber v3".
docs/intro.md Refined explanation regarding fiber.Ctx, emphasizing that returned values are mutable and reused across requests.

Poem

In Fiber's code, our path refined,
Zero allocations, swift and kind. 🌟
Version v3, we march ahead,
Performance gains, like wings, we'll spread. 🚀
With careful steps and context bright,
Our handlers dance in the server's light. ✨

— A rabbit coding through the night. 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (2)
docs/intro.md (2)

Line range hint 57-152: Replace hard tabs with spaces to maintain consistency and adhere to Markdown best practices.


Line range hint 118-118: Replace emphasis (italic) with actual headings for better structure and readability.

- **Hello, World!**
+ ### Hello, World!

- **Basic routing**
+ ### Basic routing

- **Static files**
+ ### Static files

- **Note**
+ ### Note

Also applies to: 127-127, 138-138, 152-152

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 011e83b and b5c1160.

Files selected for processing (2)
  • .github/README.md (3 hunks)
  • docs/intro.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/README.md
Additional context used
LanguageTool
docs/intro.md

[style] ~14-~14: Often, this adverbial phrase is redundant. Consider using an alternative. (FIRST_OF_ALL)
Context: ... March XX, 2024. ### Installation First of all, download and ins...

Markdownlint
docs/intro.md

57-57: Column: 1 (MD010, no-hard-tabs)
Hard tabs


58-58: Column: 1 (MD010, no-hard-tabs)
Hard tabs


60-60: Column: 1 (MD010, no-hard-tabs)
Hard tabs


68-68: Column: 1 (MD010, no-hard-tabs)
Hard tabs


84-84: Column: 1 (MD010, no-hard-tabs)
Hard tabs


86-86: Column: 1 (MD010, no-hard-tabs)
Hard tabs


87-87: Column: 1 (MD010, no-hard-tabs)
Hard tabs


88-88: Column: 1 (MD010, no-hard-tabs)
Hard tabs


90-90: Column: 1 (MD010, no-hard-tabs)
Hard tabs


123-123: Column: 1 (MD010, no-hard-tabs)
Hard tabs


133-133: Column: 1 (MD010, no-hard-tabs)
Hard tabs


134-134: Column: 1 (MD010, no-hard-tabs)
Hard tabs


144-144: Column: 1 (MD010, no-hard-tabs)
Hard tabs


145-145: Column: 1 (MD010, no-hard-tabs)
Hard tabs


146-146: Column: 1 (MD010, no-hard-tabs)
Hard tabs


147-147: Column: 1 (MD010, no-hard-tabs)
Hard tabs


148-148: Column: 1 (MD010, no-hard-tabs)
Hard tabs


158-158: Column: 1 (MD010, no-hard-tabs)
Hard tabs


159-159: Column: 1 (MD010, no-hard-tabs)
Hard tabs


118-118: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


127-127: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


138-138: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


152-152: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

Additional comments not posted (1)
docs/intro.md (1)

25-25: Consider replacing "First of all," with a more direct introduction to improve clarity and conciseness.

- First of all, [download](https://go.dev/dl/) and install Go.
+ To start, [download](https://go.dev/dl/) and install Go.

Likely invalid or redundant comment.

@ReneWerner87 ReneWerner87 merged commit 5914e92 into main Jun 20, 2024
1 check passed
@gaby gaby deleted the update-readme branch June 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants