Add JSON (Un)marshaling methods on NullUUID type #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is part of #32. |
Pull Request Test Coverage Report for Build 116
💛 - Coveralls |
zerkms
approved these changes
Jul 23, 2018
theckman
force-pushed
the
satori_go.uuid_44_adaption
branch
from
d036565
to
a491b52
Compare
theckman
force-pushed
the
satori_go.uuid_44_adaption
branch
2 times, most recently
from
1cfa150
to
ebf8642
Compare
theckman
force-pushed
the
satori_go.uuid_44_adaption
branch
from
ebf8642
to
9ad4bb4
Compare
This commit adapts satori/go.uuid#44 for our fork of the original project. This brings JSON Marshaling and Unmarshaling to the `uuid.NullUUID` type used for use with SQL databases. This is needed because `uuid.NullUUID` is a shim around `uuid.UUID`, providing the information needed by the `database/sql` package to support storing the value in a nullable column. Without these methods, the type gets converted unnecessarily to a different format than the standard `uuid.UUID` type. Signed-off-by: Tim Heckman <t@heckman.io>
theckman
force-pushed
the
satori_go.uuid_44_adaption
branch
from
9ad4bb4
to
a30993e
Compare
theckman
added a commit
that referenced
this pull request
Jul 23, 2018
Add JSON (Un)marshaling methods on NullUUID type Signed-off-by: Tim Heckman <t@heckman.io>
|
This is going to actually warrant a 3.0.0. I think changing how this serializes to JSON could be a breaking change. |
|
Should summary issue #32 be updated to mark this as merged? |
|
Came here late from the original repo, thanks for taking over maintenance. Out of curiosity, why did you put the JSON marshaller into |
|
@philippfrank I assume this was to have it alongside the NullUUID struct without thinking about how basically every file is mostly methods on that same struct for this particular project. I could see it being more appropriate in codec.go though. Is that where you had in mind as the sensible place to put it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts satori/go.uuid#44 for our fork of the
original project. This brings JSON Marshaling and Unmarshaling to the
uuid.NullUUIDtype used for use with SQL databases.This is needed because
uuid.NullUUIDis a shim arounduuid.UUID, providingthe information needed by the
database/sqlpackage to support storing thevalue in a nullable column. Without these methods, the type gets converted
unnecessarily to a different format than the standard
uuid.UUIDtype.