Auto generated URL of commit SHA references link to wrong address

[liyuan-rey]

Describe the bug
Auto generated URL of commit SHA references in markdown link to wrong address

Gogs version and commit
Gogs 0.11.91.0811

Git version
Git 2.24.1.windows.2

Operating system
Windows 10 Home (Chinese) 19041.450

Database
Unknown

To Reproduce
Steps to reproduce the behavior:

1. Edit README.md file locally, add line with a valid commit SHA value, save file.
2. Commit and push README.md to repository
3. View the render page of README.md in Gogs
4. Click the link of commit SHA references, the browser jump to wrong 404 page

Can you reproduce the bug at https://try.gogs.io?
No try yet

Expected behavior
A link with correct URL to commit SHA references.

Actual behavior
A link with wrong URL, unnecessary 'src/develop' path in the URL.

Screenshots
N/A

Additional context
N/A

[unknwon]

Thanks for the feedback!

Can you reproduce the bug at try.gogs.io?
No try yet

Please do so.

[liyuan-rey]

emm.... try.gogs.io has the same issue.

[liyuan-rey]

i can't paste the screenshot, please visit https://try.gogs.io/liyuan/issues-6300

[liyuan-rey]

[unknwon]

@liyuan-rey Thank you!

Note: The correct link should be:

-https://try.gogs.io/liyuan/issues-6300/src/master/commit/b5be65c1381188fb2f589504cafb115cdec6ab43
+https://try.gogs.io/liyuan/issues-6300/commit/b5be65c1381188fb2f589504cafb115cdec6ab43

I think the problem is here:

gogs/internal/markup/markup.go

Lines 142 to 150 in 23ff182

	// RenderSha1CurrentPattern renders SHA1 strings to corresponding links that assumes in the same repository.
	func RenderSha1CurrentPattern(rawBytes []byte, urlPrefix string) []byte {
	return []byte(Sha1CurrentPattern.ReplaceAllStringFunc(string(rawBytes[:]), func(m string) string {
	if com.StrTo(m).MustInt() > 0 {
	return m
	}
	return fmt.Sprintf(`<a href="%s/commit/%s"><code>%s</code></a>`, urlPrefix, m, tool.ShortSHA1(string(m)))
	}))
	}

Where urlPrefix contains branch portion and shouldn't.

[manfer]

gogs/internal/route/repo/view.go

Lines 85 to 101 in 23ff182

	c.Data["FileName"] = readmeFile.Name()
	if isTextFile {
	switch markup.Detect(readmeFile.Name()) {
	case markup.MARKDOWN:
	c.Data["IsMarkdown"] = true
	p = markup.Markdown(p, treeLink, c.Repo.Repository.ComposeMetas())
	case markup.ORG_MODE:
	c.Data["IsMarkdown"] = true
	p = markup.OrgMode(p, treeLink, c.Repo.Repository.ComposeMetas())
	case markup.IPYTHON_NOTEBOOK:
	c.Data["IsIPythonNotebook"] = true
	c.Data["RawFileLink"] = c.Repo.RepoLink + "/raw/" + path.Join(c.Repo.BranchName, c.Repo.TreePath, readmeFile.Name())
	default:
	p = bytes.Replace(p, []byte("\n"), []byte(`<br>`), -1)
	}
	c.Data["FileContent"] = string(p)
	}

Not sure if changing line 90 to,

				p = markup.Markdown(p, c.Repo.RepoLink, c.Repo.Repository.ComposeMetas())

is a proper solution or if it will have any undesirable effect somewhere else.

If it is the proper solution probably 93 should be changed too,

				p = markup.OrgMode(p, c.Repo.RepoLink, c.Repo.Repository.ComposeMetas())

[unknwon]

@manfer Thanks for looking! I think relative links to a file will break, e.g. link to another Markdown, display an image.

Another option seems achievable would be adding something like repoLink in the map that is returned by c.Repo.Repository.ComposeMetas() (the docstring says it is for the purpose of external issue tracker but we can expand the use cases)?