Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - 20469 sbom status and download issue #20471

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

xuelichao
Copy link
Contributor

@xuelichao xuelichao commented May 22, 2024

Thank you for contributing to Harbor!

fix sbom status and download issue

Issue being fixed

Fixes #20469

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao requested a review from a team as a code owner May 22, 2024 10:35
@xuelichao xuelichao added release-note/ignore-for-release Do not include PR or Issue for release notes target/2.11.0 labels May 22, 2024
Signed-off-by: xuelichao <xuel@vmware.com>
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.36%. Comparing base (b7b8847) to head (2b3d3e0).
Report is 195 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20471      +/-   ##
==========================================
- Coverage   67.56%   66.36%   -1.21%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113186    +4005     
  Branches     2719     2842     +123     
==========================================
+ Hits        73768    75111    +1343     
- Misses      31449    34007    +2558     
- Partials     3964     4068     +104     
Flag Coverage Δ
unittests 66.36% <ø> (-1.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 567 files with indirect coverage changes

@zyyw zyyw added area/ui release-note/update Update or Fix and removed release-note/ignore-for-release Do not include PR or Issue for release notes labels May 23, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 3352a72 into goharbor:main May 23, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBOM column showing Not Generated and SBOM download link not working
5 participants