Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry with exponential backoff for GetRemote for 429 and other temporary HTTP errors #11312

Closed
davidejones opened this issue Jul 31, 2023 · 1 comment · Fixed by #11326
Closed

Add retry with exponential backoff for GetRemote for 429 and other temporary HTTP errors #11312

davidejones opened this issue Jul 31, 2023 · 1 comment · Fixed by #11326
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.117.0

Comments

@davidejones
Copy link
Contributor

davidejones commented Jul 31, 2023 •
edited
Loading

We have a hugo site that is making a number of GetRemote calls to an authenticated api. We hit a point where we are receiving 429 Too Many Requests errors due to the requests per second rate limit etc.

As most apis will have some form of rate limits this is a proposal to include some solution/strategy for it. Perhaps some configurable limit to the requests per second of getremote? or some retry with exponential backoff?
@bep bep removed the NeedsTriage label Jul 31, 2023
@bep bep added this to the v0.116.0 milestone Jul 31, 2023
@bep bep added Enhancement and removed Proposal labels Jul 31, 2023
@bep bep changed the title GetRemote support for rate limits Add retry with exponential backoff for GetRemote for 429 and other temporary HTTP errors Jul 31, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep self-assigned this Aug 3, 2023
@bep bep mentioned this issue Aug 3, 2023
Merged
bep added a commit to bep/hugo that referenced this issue Aug 3, 2023
@bep
Add retry with exponential backoff in resources.GetRemote for tempora…
dc5fd7b 
…ry HTTP errors

Fixes gohugoio#11312
bep added a commit to bep/hugo that referenced this issue Aug 3, 2023
@bep
Add retry with exponential backoff in resources.GetRemote for tempora…
cddce26 
…ry HTTP errors

Fixes gohugoio#11312
bep added a commit to bep/hugo that referenced this issue Aug 4, 2023
@bep
Add retry with exponential backoff in resources.GetRemote for tempora…
bd10d05 
…ry HTTP errors

Fixes gohugoio#11312
bep added a commit to bep/hugo that referenced this issue Aug 4, 2023
@bep
Add retry in resources.GetRemote for temporary HTTP errors
db03991 
Fixes gohugoio#11312
bep added a commit to bep/hugo that referenced this issue Aug 4, 2023
@bep
Add retry in resources.GetRemote for temporary HTTP errors
b103842 
Fixes gohugoio#11312
@bep bep closed this as completed in #11326 Aug 4, 2023
bep added a commit that referenced this issue Aug 4, 2023
@bep
Add retry in resources.GetRemote for temporary HTTP errors
a3d42a2 
Fixes #11312
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.117.0
Development

Successfully merging a pull request may close this issue.

Add retry in resources.GetRemote for temporary HTTP errors bep/hugo
2 participants
@bep @davidejones