Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the Resource.Name normalization #12142

Closed
bep opened this issue Feb 24, 2024 · 4 comments · Fixed by #12149
Closed

Revert the Resource.Name normalization #12142

bep opened this issue Feb 24, 2024 · 4 comments · Fixed by #12149

Comments

@bep
Copy link
Member

bep commented Feb 24, 2024

I don't think it's needed. I'm not totally sure about that, but I need to have a look before people start using this new method.

@bep bep added the Proposal label Feb 24, 2024
@bep bep added this to the v0.123.4 milestone Feb 24, 2024
@bep bep self-assigned this Feb 24, 2024
@jmooring
Copy link
Member

It would be useful to obtain "Sunrise in Bryce Canyon.jpg" instead of "sunrise-in-bryce-canyon.jpg", where the file name is the meta data. An alternative (without additional front matter) is to do:

{{ path.Base .Key | something.QueryUnescape }}

@bep
Copy link
Member Author

bep commented Feb 24, 2024

I mainly created this issue to "think about this" before committing to this new API.

@jmooring
Copy link
Member

We scratched this particular user itch by running exiftool recursively before each build, stuffing the file name (less extension) in the ImageDescription EXIF tag.

bep added a commit to bep/hugo that referenced this issue Feb 25, 2024
Which means that .Name now returns the same as it did in 0.122.0.

Closes gohugoio#12142
@bep bep changed the title Remove NameOriginal Revert the Resource.Name normalization Feb 25, 2024
bep added a commit that referenced this issue Feb 25, 2024
Which means that .Name now returns the same as it did in 0.122.0.

Closes #12142
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants