Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit/noise: Rename hugo.IsMultiHost and hugo.IsMultiLingual #12232

Closed
jmooring opened this issue Mar 10, 2024 · 4 comments · Fixed by #12238
Closed

nit/noise: Rename hugo.IsMultiHost and hugo.IsMultiLingual #12232

jmooring opened this issue Mar 10, 2024 · 4 comments · Fixed by #12238
Labels
Enhancement Outdated
Milestone
v0.123.9

Comments

@jmooring
Copy link
Member

jmooring commented Mar 10, 2024 •
edited
Loading

Feel free to close, but both multihost and multilingual are one word without hyphenation, so these seem a better choice:

  • hugo.IsMultihost
  • hugo.IsMultilingual

I noticed yesterday that, excluding the methods exposed to the templates, we are inconsistent internally:

  • IsMultihost (no camel case)
  • IsMultiLingual (camel case)

I'd like to change the exposed methods and make the internal usage consistent with the exposed methods.

hugo.IsMultiHost was just introduced last week in v0.123.8, so if we (you) want to change this, now would be a good time.
@bep bep added this to the v0.123.9 milestone Mar 13, 2024
@bep
Copy link
Member

bep commented Mar 13, 2024

Yea, that makes sense. I'm back from a short vacation now and I'm going to collect some issues into a final v0.123.9 (before moving on to 0.124) release.

  • IsMultiHost I suggest that we just rename.
  • IsMultiLingual, probably best to deprecate and create a copy.

@jmooring
Copy link
Member Author

  • IsMultiHost I suggest that we just rename.
  • IsMultiLingual, probably best to deprecate and create a copy.

I'm assuming the above are reversed.

  • hugo.IsMultiHost was part of 123.8, so should be deprecated and copied.
  • hugo.IsMultiLingual has been merged and not released, so we can just rename.

I will submit a PR. Shout if you think I got it wrong.

@bep
Copy link
Member

bep commented Mar 13, 2024

I'm assuming the above are reversed.

It was in a roundabout way, but you are right.

jmooring added a commit to jmooring/hugo that referenced this issue Mar 13, 2024
@jmooring
common/hugo: Rename IsMultiHost and IsMultiLingual
a0c6795 
hugo.IsMultiHost => hugo.IsMultihost
hugo.IsMultiLingual => hugo.IsMultilingual

Closes gohugoio#12232
@jmooring jmooring mentioned this issue Mar 13, 2024
Merged
jmooring added a commit to jmooring/hugo-docs that referenced this issue Mar 13, 2024
@jmooring
update MultiLingual and MultiHost methods/functions
3b6d075 
- Deprecate .Site.MultiLingual in favor of hugo.IsMultilingual
- Rename hugo.IsMultiHost in favor of hugo.IsMultihost. Cannot Deprecate
  in documentation because they have the same published path.

See gohugoio/hugo#12232
@jmooring jmooring mentioned this issue Mar 13, 2024
Merged
jmooring added a commit to jmooring/hugo-docs that referenced this issue Mar 13, 2024
@jmooring
Update MultiLingual and MultiHost methods/functions
09a94b9 
- Deprecate .Site.MultiLingual in favor of hugo.IsMultilingual
- Rename hugo.IsMultiHost to hugo.IsMultihost. Cannot deprecate
  in documentation because they have the same published path, but this
  shouldn't be a problem because hugo.IsMultiHost was introduced in the
  last patch release.

See gohugoio/hugo#12232
bep pushed a commit that referenced this issue Mar 13, 2024
@jmooring @bep
common/hugo: Rename IsMultiHost and IsMultiLingual
dc6a292 
hugo.IsMultiHost => hugo.IsMultihost
hugo.IsMultiLingual => hugo.IsMultilingual

Closes #12232
jmooring added a commit to jmooring/hugo-docs that referenced this issue Mar 16, 2024
@jmooring
Update MultiLingual and MultiHost methods/functions
89ed635 
- Deprecate .Site.MultiLingual in favor of hugo.IsMultilingual
- Rename hugo.IsMultiHost to hugo.IsMultihost. Cannot deprecate
  in documentation because they have the same published path, but this
  shouldn't be a problem because hugo.IsMultiHost was introduced in the
  last patch release.

See gohugoio/hugo#12232
jmooring added a commit to jmooring/hugo-docs that referenced this issue Mar 16, 2024
@jmooring
Update MultiLingual and MultiHost methods/functions
090ed35 
- Deprecate .Site.MultiLingual in favor of hugo.IsMultilingual
- Rename hugo.IsMultiHost to hugo.IsMultihost. Cannot deprecate
  in documentation because they have the same published path, but this
  shouldn't be a problem because hugo.IsMultiHost was introduced in the
  last patch release.

See gohugoio/hugo#12232
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.123.9
Development

Successfully merging a pull request may close this issue.

common/hugo: Rename IsMultiHost and IsMultiLingual jmooring/hugo
2 participants
@jmooring @bep