Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description to Page.Params #1484

Closed
bep opened this issue Oct 12, 2015 · 5 comments
Closed

Add description to Page.Params #1484

bep opened this issue Oct 12, 2015 · 5 comments
Labels
Enhancement Outdated
Milestone
v0.16

Comments

@bep
Copy link
Member

bep commented Oct 12, 2015

Now it is set on Page.Description -- it would be useful if it was ALSO set in the Params map.

See #1462
@arunk-s
Copy link
Contributor

arunk-s commented Oct 24, 2015

I am interested to work on the issue. Can you explain what's exactly is needed ?

@bep
Copy link
Member Author

bep commented Oct 24, 2015

See

https://github.com/spf13/hugo/blob/c274e21356826a6aa1e04d875a37838a6fe1a6c6/hugolib/page.go#L508

Just put the same value into the Page.Params map with "description" as key.

arunk-s added a commit to arunk-s/hugo that referenced this issue Oct 26, 2015
@arunk-s
Set description in Page.Params map
edd4112 
Fix gohugoio#1484
@spf13
Copy link
Contributor

spf13 commented Nov 28, 2015

@arunk-s do you want to make a Pull request?

@arunk-s
Copy link
Contributor

arunk-s commented Nov 28, 2015

@spf13 I've actually created a pull requested quite earlier: #1522.

@bep bep closed this as completed in 9569d11 Dec 12, 2015
@bep bep added this to the v0.16 milestone Dec 12, 2015
bramp pushed a commit to bramp/hugo that referenced this issue Dec 17, 2015
@bep @bramp
Duplicate p.Description in Params map
01c14e1 
Fixes gohugoio#1484
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@bep @tychoish
Duplicate p.Description in Params map
b035068 
Fixes gohugoio#1484
bep added a commit that referenced this issue Jul 4, 2021
@bep
Squashed 'docs/' changes from 710856e5a..6ebb5dad9
7eb0e10 
6ebb5dad9 Remove file
27cc23ef4 Hugo 0.84.4
94dccbfa4 Merge branch 'tempv0.84.4'
e9d8b61fb releaser: Add release notes to /docs for release of 0.84.4
51e472005 Improve readability of examples on shortcode templates page
0aef26479 Fix lookup order typos (#1484)
534a527fe Fix two typos (#1483)
394aabd5a Higo "0.84.3
03ee92c1c Merge branch 'tempv0.84.3'
96a8be0f1 releaser: Add release notes to /docs for release of 0.84.3
9a770323f Update index.md
7f65cfcbe Hugo 0.84.2
444422515 releaser: Add release notes to /docs for release of 0.84.2
a2f29c5d8 modules: Add module.import.noMounts config
e00e4a7e7 releaser: Add release notes to /docs for release of 0.84.2
af04b53b3 modules: Add module.import.noMounts config
f7d5669c7 Remove Appernetic (#1481)
14f8d4029 Clarify interaction of sections and top-level leaf bundles
d140b6a62 Update lookup-order.md
399904959 Update shortcode-templates.md
e78aa4865 Hugo 0.84.1
35d7c1c22 Merge branch 'tempv0.84.1'
a6be65b0d releaser: Add release notes to /docs for release of 0.84.1
7b3b3ca45 Hugo 0.84.0 News Grammar fixes
cbc23bf5a Remove trailing newlines
69349198d Fix erroridf docs
dbc1157c1 Fix missing deep

git-subtree-dir: docs
git-subtree-split: 6ebb5dad9a87655196c0990d88d50a2248df5c54
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.16
Development

No branches or pull requests
3 participants
@spf13 @bep @arunk-s