Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default baseurl of replace-this-with-your-hugo-site.com is a very suspicious #2264

Closed
ghost opened this issue Jul 8, 2016 · 7 comments
Closed

Comments

@ghost
Copy link

ghost commented Jul 8, 2016

Going through the quick start and noticed that a generated site contains the url "replace-this-with-your-hugo-site.com" as the default baseurl in config.toml (and in the docs). This url, which may be clicked unknowingly by a new user (I did, lol), and it's very suspicious (executed script redirecting to pages my adblocker dislikes and pops up notices about infected computer and plays beeping sounds, etc).

Here's a google search showing the link to this site. Now appears to forward through some advertising url to a real estate site.
https://www.google.com/#q=http:%2F%2Freplace-this-with-your-hugo-site.com%2F

Can we possibly replace the baseurl with something more benign like the gohugo.io url or something that won't resolve to a real domain? Doesn't seem like the ideal thing for a new user to see just when trying out Hugo. Even just dropping the ".com" would probably be an improvement.

Thanks very much. This is my first posted issue so hopefully it's in the right place. I'd be interested in contributing to Hugo's development at some point so let me know if I can help directly with this -- e.g., updating the code and docs.

@bep
Copy link
Member

bep commented Jul 8, 2016

Thanks for the heads up, what those scammers will do to to earn a few extra cents is incredible.

@bep bep added the Docs label Jul 8, 2016
@ghost
Copy link
Author

ghost commented Jul 8, 2016

Absolutely, you're welcome =)

@bep
Copy link
Member

bep commented Jul 8, 2016

 find . -name "*.md" | xargs grep "replace-this-with-your-hugo-site.com"
./content/overview/quickstart.md:baseurl = "http://replace-this-with-your-hugo-site.com/"
./content/tutorials/creating-a-new-theme.md:baseurl = "http://replace-this-with-your-hugo-site.com/"
./content/tutorials/creating-a-new-theme.md:    <h1><a href="http://replace-this-with-your-hugo-site.com/article/second/">second</a></h1>
./content/tutorials/creating-a-new-theme.md:    <h1><a href="http://replace-this-with-your-hugo-site.com/article/first/">first</a></h1>
./content/tutorials/creating-a-new-theme.md:  <p><a href="http://replace-this-with-your-hugo-site.com/">Home</a></p>
./content/tutorials/creating-a-new-theme.md:  <p><a href="http://replace-this-with-your-hugo-site.com/">Home</a></p>
./content/tutorials/creating-a-new-theme.md:  <p><a href="http://replace-this-with-your-hugo-site.com/">Home</a></p>
./content/tutorials/creating-a-new-theme.md:    <h1><a href="http://replace-this-with-your-hugo-site.com/about/">about</a></h1>
./content/tutorials/creating-a-new-theme.md:    <h1><a href="http://replace-this-with-your-hugo-site.com/article/second/">second</a></h1>
./content/tutorials/creating-a-new-theme.md:    <h1><a href="http://replace-this-with-your-hugo-site.com/article/first/">first</a></h1>
./content/tutorials/creating-a-new-theme.md:      <h2><a href="http://replace-this-with-your-hugo-site.com/article/second/">second</a></h2>
./content/tutorials/creating-a-new-theme.md:      <h2><a href="http://replace-this-with-your-hugo-site.com/article/first/">first</a></h2>
./content/tutorials/creating-a-new-theme.md:      <h2><a href="http://replace-this-with-your-hugo-site.com/about/">about</a></h2>
./content/tutorials/creating-a-new-theme.md:  <p><a href="http://replace-this-with-your-hugo-site.com/">Home</a></p>
./content/tutorials/creating-a-new-theme.md:  <p><a href="http://replace-this-with-your-hugo-site.com/">Home</a></p>

Not sure what to put there, though ...

@knarz
Copy link

knarz commented Jul 8, 2016

How about example.org?

@bep bep closed this as completed in 4a48b5f Jul 8, 2016
@anthonyfok anthonyfok added this to the v0.17 milestone Jul 10, 2016
@anthonyfok
Copy link
Member

Thank you all for having this fixed! I should have known better than to have picked this somewhat convoluted domain name! Though it being registered by a spammer is a surprise to me. Lesson learned.

@LiaungYip
Copy link
Contributor

LiaungYip commented Aug 8, 2016

I got caught by this as well.

In addition to the occurrences in the docs, a lot of themes have baseurl = "replace-this-with-your-hugo-site.com" in their default config.toml - Blackburn and hugo-material-docs, are some examples, I think.

See https://github.com/search?l=toml&q=replace-this-with-your-hugo-site&type=Code&utf8=%E2%9C%93 for ~600 examples in the wild.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants