-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdownify function does not call render-link hook #6650
Labels
Milestone
Comments
|
Will give |
jakejarvis
changed the title
Markdown links passed to shortcode via .Inner not affected by render-link hook
Markdownify function does not call render-link hook
Dec 20, 2019
|
2 tasks
benesch
added a commit
to benesch/materialize
that referenced
this issue
Oct 6, 2020
The markdownify filter does not properly support render hooks, but the slightly-clunkier .RenderString method does. See gohugoio/hugo#6650 for context. The observable behavior of this is that markdownify does not properly add the base URL prefix (i.e. /docs) to links within its input, while RenderString does.
benesch
added a commit
to benesch/materialize
that referenced
this issue
Oct 6, 2020
The markdownify filter does not properly support render hooks, but the slightly-clunkier .RenderString method does. See gohugoio/hugo#6650 for context. The observable behavior of this is that markdownify does not properly add the base URL prefix (i.e. /docs) to links within its input, while RenderString does.
It seems like this issue was resolved with creation of the .RenderString page method. For example, within a shortcode:
Can we close this issue? |
davidmytton
added a commit
to consoledotdev/home
that referenced
this issue
Mar 29, 2021
yuanji-dev
added a commit
to yuanji-dev/futu
that referenced
this issue
Oct 15, 2021
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Not an urgent bug, but I have an image shortcode capable of passing a markdown caption that's retrieved by
.Inner
. Everything renders correctly as HTML (same as v0.61) but myrender-link.html
hook doesn't seem to be called by it.This might be a bigger problem with
markdownify
not calling the new hooks?shortcodes/image.html:
_default/_markup/render-link.html:
test.md:
renders...
instead of...
Hope this makes sense!
The text was updated successfully, but these errors were encountered: