-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable color output on recent Windows 10 #8209
Labels
Milestone
Comments
We should try to fix this, but I'm not keen on adding that entire windows package, so we should try to figure this out without. |
Well in fact the syscall.GetVersion() may not be the way to go (deprecated), see BishopFox/sliver#108 (comment) It takes a combination of syscall (call to "RtlGetVersion") and unsafe access to retrieve the build value apparently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Referencing #4414 and #5344
Recent builds of Windows 10 have Ansi color sequences enabled by default.
Can you change the IsTerminal runtime check in
common/terminal/colors.go
to allow colors when Windows 10 >= 1909?You could use something like https://github.com/microsoft/hcsshim/blob/master/osversion/osversion_windows.go#L35
and 1909 is 10.0 build 18363 (from [1])
[1] https://docs.microsoft.com/en-us/windows/release-information/
The text was updated successfully, but these errors were encountered: