tpl: Escape .Title in built-in image and link render hooks #12411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmooring
requested changes
Apr 22, 2024
There was a problem hiding this comment.
I tested your link and image examples against https://spec.commonmark.org/dingus/. With the changes below our output (with html/template) matches theirs.
tpl/tplimpl/embedded/templates/_default/_markup/render-link.html
Outdated
Show resolved
Hide resolved
tpl/tplimpl/embedded/templates/_default/_markup/render-image.html
Outdated
Show resolved
Hide resolved
bep
changed the title
Co-authored-by: Joe Mooring <joe@mooring.com>
|
This was mentioned as a security fix in the v0.125.3 release notes. Are you planning to request a CVE? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These templates were added in Hugo v0.123.0, and in the common case disabled by default, see https://gohugo.io/getting-started/configuration-markup/#renderhooksimageenabledefault