fix issue #79: add /v6 module import suffix #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sohamkamani I've added
/v6
import suffix to resolve issue #79 introduced withv5.1.0
release with #40.According to https://github.com/golang/go/wiki/Modules#why-must-major-version-numbers-appear-in-import-paths the major version must present in import paths.
If you wish, I could do it in v5 module, to fix the buggy
v5.1.0
version, but it's strongly recommended to increase major version after adopting go modules: https://github.com/golang/go/wiki/Modules#incrementing-the-major-version-when-first-adopting-modules-with-v2-packages, so I've made itv6
.And please have a look at https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher
In short, there could be some problems with
godep
users with major go.mod in master. So we could introduce better compatibility withv6
subdirectory for non-gomod users.But if you dropped Gopkg.toml support, maybe it's unnecessary.
Let's discuss an fix it ASAP to have better go.mod support 🙇