Skip to content

backport of fix for config.Time test using expired certificates #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

backport of fix for config.Time test using expired certificates #259

merged 1 commit into from
Jan 28, 2025

Conversation

archanaravindar
Copy link
Collaborator

backport of fix for config.Time test using expired certificates to Go1.15
https://go-review.googlesource.com/c/go/+/640237

@archanaravindar archanaravindar self-assigned this Jan 28, 2025
@archanaravindar archanaravindar requested review from derekparker and removed request for derekparker January 28, 2025 07:50
dbenoit17
dbenoit17 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@dbenoit17 dbenoit17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about the failing tests here. The target branch only supports ubi8, and the compatibility issues seen on other OS versions are expected.

@archanaravindar archanaravindar merged commit 388ec8a into golang-fips:go1.15-openssl-fips Jan 28, 2025
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbenoit17 dbenoit17 dbenoit17 approved these changes

Assignees

@archanaravindar archanaravindar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archanaravindar @dbenoit17