Skip to content

fixed redis timeout issue #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2022
Merged

fixed redis timeout issue #15

merged 1 commit into from
Dec 11, 2022

Conversation

sankethkini
Copy link
Contributor

ISSUE

  • currently redis block time is 0 this means our application will wait for new messages without getting timedout. If for some reasons let's say our request got timedout then we will end all the reading process so we will not read any messages at all.

FIX

  • fixed the above issue by keeping a reasonable timeout (60s) then after timeout the loop will not end rather than it will wait for new messages.

@sankethkini sankethkini mentioned this pull request Oct 30, 2022
Closed
@appleboy appleboy merged commit 655c933 into golang-queue:main Dec 11, 2022
appleboy added a commit that referenced this pull request Dec 11, 2022
@appleboy
chore(redis): support block time in XReadGroup
603fcac 
ref: #15

Signed-off-by: Bo-Yi.Wu <appleboy.tw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sankethkini @appleboy