New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(re)Spec and implement command set #277

Closed
sdboyer opened this Issue Mar 2, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@sdboyer
Copy link
Member

sdboyer commented Mar 2, 2017

In the original spec, the committee elected to aim for explicit commands and an entirely CLI-driven UI for dep. However, after some discussion and getting our hands dirty, we decided (#213 (comment)) to change course and focus instead on a workflow that presumes hand-edited manifest files and a more minimal command set.

This meta-issue is to track the writing of a new spec (WIP here), and then implementing it.

While we of course expect these commands will continue to evolve in the future, this issue specifically aims to track implementation with the goal of having a command set that could reasonably be merged directly into the go toolchain. Basic completeness per the spec (not bug free-ness), is the rubric for completion of this issue.

Related/sub-issues:

  • #186 - alternate init modes
  • #145 - no-op on ensure should actually be no-op
  • #161 - dep status, memo
  • #302 - report when manifest contains ineffectual constraints
  • #303 - incorporating non-imported packages
  • #343 - generate Gopkg.toml with examples
  • #481 - drop remove subcommand
  • #489 - overhaul ensure
@jbrodriguez

This comment has been minimized.

Copy link

jbrodriguez commented Mar 14, 2017

With regards to this WIP flag for init

-no-tools: skip searching for metadata files from legacy tools

Shouldn't the default be to skip and the flag to actually search for legacy tools ?

Eventually there will be no legacy and you'd still need to pass the flag.

@sdboyer

This comment has been minimized.

Copy link
Member

sdboyer commented Mar 14, 2017

@jbrodriguez i was gonna say that that seems like a good comment to make in the doc...then realized i had comments disabled 😛

It shouldn't be necessary to pass -no-tools, even if there's no tool metadata available. It should fall through just fine on its own. Might be more intuitive if the flag is -skip-tools, though; I've updated accordingly.

@sdboyer

This comment has been minimized.

Copy link
Member

sdboyer commented Apr 17, 2017

I made considerable progress on the WIP spec last night; a new approach to dep ensure is now at least mostly sketched out. It's certainly in a place where folks could start iterating on it, though we'll doubtless need to take it over the course of a few PRs. I'd prefer to avoid it, but we could also use a long-running feature branch if need be.

@agnivade

This comment has been minimized.

Copy link
Member

agnivade commented Jan 17, 2018

@sdboyer - Shouldn't the checkbox beside #302 be ticked now in your first comment ?

@sdboyer

This comment has been minimized.

Copy link
Member

sdboyer commented Jan 25, 2018

it should, heh, now that that's finally finally done

@sdboyer

This comment has been minimized.

Copy link
Member

sdboyer commented Jan 25, 2018

and so, this long-open issue can go away, finally

@sdboyer sdboyer closed this Jan 25, 2018

@ancarda

This comment has been minimized.

Copy link

ancarda commented Feb 10, 2018

This issue is linked on the Roadmap page as "Stable command set" but doesn't have a strike-through like "Stable manifest and lock files". Is this considered closed? If so, is there some way to edit that page (e.g. via a pull request)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment