slog: allow package docs to appear #56
Conversation
In doc.go move the package declaration to directly below the documentation comment, so it shows up in pkg.go.dev etc.
|
This PR (HEAD: 45c7c20) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/exp/+/462038 to see it. Tip: You can toggle comments from me using the |
|
Message from Michael Knyszek: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/462038. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/462038. |
|
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/462038. |
|
Ping @jba -- would be nice to read the extensive documentation on pkg.go.dev rather than just in the source. |
|
Thanks. Sorry for the delay. Just waiting for another Googler's +2 and I'll
submit.
…On Fri, Feb 10, 2023 at 7:37 AM Piers ***@***.***> wrote:
Ping @jba <https://github.com/jba> -- would be nice to read the extensive
documentation on pkg.go.dev rather than just in the source.
—
Reply to this email directly, view it on GitHub
<#56 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENAOZLJYLJTNNBICUJGCJTWWYY7VANCNFSM6AAAAAAT3ITWMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Message from Jonathan Amsterdam: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/462038. |
|
Message from Alan Donovan: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/462038. |
In doc.go, the large package doc comment was not in the right place in order to appear on pkg.go.dev etc. Fixed by re-arranging so comment appears directly above package declaration. Change-Id: Idde2f089c5e967a3127eeb8afb56b6f657c10a60 GitHub-Last-Rev: 45c7c20 GitHub-Pull-Request: #56 Reviewed-on: https://go-review.googlesource.com/c/exp/+/462038 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>
|
This PR is being closed because golang.org/cl/462038 has been merged. |
In doc.go, the large package doc comment was not in the right place in order to appear on pkg.go.dev etc. Fixed by re-arranging so comment appears directly above package declaration.